Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

Upgrade to ethereumjs-config 2.0 libs #133

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented Oct 30, 2020

This PR upgrades to the ethereumjs-config 2.0 libs and fixes the new lint issues.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 94.555% when pulling e317d6f on upgrade-config-2.0 into aa9e47c on master.

@cgewecke cgewecke self-requested a review October 30, 2020 20:06
Copy link

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 💯

Just a review note: coveralls is showing a drop w/ new lines missed but they're wrong.

In trieNode.ts the code was re-ordered - the "new" missed hits are also missed on master (at a different location)

@holgerd77 holgerd77 merged commit 3be5389 into master Nov 2, 2020
@holgerd77 holgerd77 deleted the upgrade-config-2.0 branch November 2, 2020 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants